Re: [GSoC PATCH] pathspec: fix sign comparison warnings

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 13, 2025, 15:33 UTC
Message-ID: <xmqqcyelq714.fsf@gitster.g>
In-Reply-To: <CAOLa=ZRNJD7NqceGQ4B8ox+50m2q1nU1t29x7O0roc=-_4ww0w@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> Also a bigger question is, shouldn't the type of `pathspec.nr` and
> 'istate.cache_nr' be the actual change required? Shouldn't they be set
> to 'size_t'?

Please do not blindly advocate the idea that size_t is always the right type for any countables. It is not.

Platform natural way to count things is either "unsigned int", if you are only counting, or "int", if you need to be able to signal an unusual state other than "here is now many we have in the set", like how index related functions uses (-pos-1) to signal a location in the same range with different meanings.