Re: [PATCH v2 1/4] userdiff: add javascript diff driver

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 23, 2025, 18:09 UTC
Message-ID: <xmqqcyau5nz4.fsf@gitster.g>
In-Reply-To: <20250623090538.154858-2-derick.william.moraes@gmail.com>

"Derick W. de M. Frias" <derick.william.moraes@gmail.com> writes:

Show 8 quoted lines

> --- a/userdiff.c
> +++ b/userdiff.c
> @@ -238,33 +238,43 @@ PATTERNS("java",
>  	 "|[-+*/<>%&^|=!]="
>  	 "|--|\\+\\+|<<=?|>>>?=?|&&|\\|\\|"),
>  PATTERNS("javascript",
> -     /* conventional named functions */
> -     "^[ \t]*(async[ \t]+)?function[ \t]*\\*?[ \t]*([$_a-zA-Z][$_a-zA-Z0-9]*)[ \t]*\\(.*$|"

Curious to see that anything needs to be removed from "javascript" section, when we do not have any patterns for the language in the file. Which version of Git is this patch meant to apply to?