Re: [PATCH 2/4] doc: git-push: clarify "where to push"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 27, 2025, 00:05 UTC
- Message-ID
- <xmqqcy8hfx2e.fsf@gitster.g>
- In-Reply-To
- <36112c30bcf881f48c3de23dcae2b74e31d9a565.1756240823.git.gitgitgadget@gmail.com>
"Julia Evans via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 7 quoted lines
> From: Julia Evans <julia@jvns.ca>
>
> Signed-off-by: Julia Evans <julia@jvns.ca>
>
> Be clearer about what we're describing ("which repository" instead of
> "what to push"), and start with a positive "try X, then Y, then Z"
> instead of a negative ("if X is not specified..").Since I like this simple rule so much, if it is generally applicable everywhere, I'd like to have it or a variant of it in one of our developer facing documentation as a tip to write better documentation.
> Signed-off-by: Julia Evans <julia@jvns.ca>
There is some funny ordering problem with the commit log body and sign-off.
Show 20 quoted lines
> --- > Documentation/git-push.adoc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/git-push.adoc b/Documentation/git-push.adoc > index e73b64f61fd0..5c934486c33d 100644 > --- a/Documentation/git-push.adoc > +++ b/Documentation/git-push.adoc > @@ -22,10 +22,10 @@ DESCRIPTION > Updates one or more branches, tags, or other references in a remote > repository from your local repository. > > -When the command line does not specify where to push with the > -`<repository>` argument, `branch.*.remote` configuration for the > -current branch is consulted to determine where to push. If the > -configuration is missing, it defaults to 'origin'. > +To decide which repository to push to, Git uses the `<repository>` > +argument (for example `git push dev`), then if that's not specified the > +`branch.*.remote` configuration for the current branch, and then defaults > +to `origin`.
Very nicely done.
> When the command line does not specify what to push with `<refspec>...` > arguments or `--all`, `--mirror`, `--tags` options, the command finds