Re: [PATCH 2/7] odb/source-inmemory: signal missing objects via positive return
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 18, 2026, 18:05 UTC
- Message-ID
- <xmqqcxvfz4lu.fsf@gitster.g>
- In-Reply-To
- <20260818-pks-odb-generic-corrupt-objects-v1-2-ec234567510f@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 21 quoted lines
> The in-memory source returns a negative value from its > `read_object_info()` callback when the object in question does not > exist. Adapt the callback to return a positive value for missing objects > according to the new calling convention. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > odb/source-inmemory.c | 2 +- > t/unit-tests/u-odb-inmemory.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/odb/source-inmemory.c b/odb/source-inmemory.c > index 3e71611b8e..57183daf4d 100644 > --- a/odb/source-inmemory.c > +++ b/odb/source-inmemory.c > @@ -66,7 +66,7 @@ static int odb_source_inmemory_read_object_info(struct odb_source *source, > > object = find_cached_object(inmemory, oid); > if (!object) > - return -1; > + return 1;
Let's not define "any positive value means this single thing: it does not exist" and then return a mysterious and unspecified hard coded constant like this. Instead perhaps something along this line?
enum odb_roi_status {
ODB_ROI_SUCCESS = 0,
ODB_ROI_MISSING = 1,
ODB_ROI_IO_ERROR = -1,
...
};As I already said, I personally prefer to define MISSING also as a negative value.