git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] replay: add signing support

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 28, 2026, 15:23 UTC
Message-ID
<xmqqcxtxo0vx.fsf@gitster.g>
In-Reply-To
<aroaOsUFWt2lYOVS@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 19 quoted lines
> Hi,
>
> On Fri, Sep 25, 2026 at 04:53:46PM -0400, Patrick Monette wrote:
>> This pair of commits fixes a FIXME in replay.c. With this, it's possible
>> to sign commits using `git replay`.
>> 
>> To follow the convention of git plumbing commands, where they must
>> behave the same regardless of user config, `commit.gpgSign` is
>> intentionally ignored.
>> 
>> The first patch fixes pick_regular_commit() to ensure failures to create
>> commits are correctly handled, which can now happen more easily because
>> of signing.
>
> Note that there's already a patch series in flight that's adding the
> infra to sign commits at [1]. Your patches will conflict with that
> series, even though you're ultimately adapting git-replay(1) and not
> git-history(1). So I'd suggest that once the series at [1] land, you can
> maybe rebase your changes and then send a new version.

Ah, the other one says "history" but touches the same replay machinery to update with the signature feature, hence this will need to take advantage of that. The sequencing makes sense.

> Patrick
>
> [1]: <20260912160045.36064-1-git@5ouma.me>
Previous: Patrick Steinhardt
Message 8 of 8 in “replay: add signing support”
  1. 0/2 replay: add signing supportPatrick Monette, Sep 25, 2026
  2. 1/2 replay: handle failure to create commitsPatrick Monette, Sep 25, 2026
  3. Patrick SteinhardtSep 28, 2026
  4. 2/2 replay: add the -S optionPatrick Monette, Sep 25, 2026
  5. Patrick SteinhardtSep 28, 2026
  6. Junio C HamanoOct 2, 2026
  7. Patrick SteinhardtSep 28, 2026
  8. Junio C HamanoSep 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.