git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t: use test_must_fail instead of NOT operator

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 16, 2026, 16:07 UTC
Message-ID
<xmqqcxs4n4k0.fsf@gitster.g>
In-Reply-To
<20261115-t-tmf-refactor-v1-1-d7a95cdeaedd@gmail.com>
Hardik Kumar <hardikxk@gmail.com> writes:
Show 15 quoted lines
> Replace `!` operator with `test_must_fail` for multiple unit tests where
> a git command is expected to fail.
>
> `test_must_fail` handles edge cases like a command killed by a signal
> or a crash because of a segfault, by actually failing the test unlike
> the `!` operator which would result in the test being passed as the
> crash is accepted as a failure (the test is expected to fail).
>
> Signed-off-by: Hardik Kumar <hardikxk@gmail.com>
> ---
>  t/t5564-http-proxy.sh       | 4 ++--
>  t/t6030-bisect-porcelain.sh | 4 ++--
>  t/t7400-submodule-basic.sh  | 4 ++--
>  t/t9001-send-email.sh       | 2 +-
>  4 files changed, 7 insertions(+), 7 deletions(-)

All of them look sensible, but I am curious why you chose only these, among 14 hits in

    $ git grep -l '^[ 	]*! git ' t/
I suspect that it is because these are ...
> -	! git clone -c http.proxy=localhost/path https://example.com/repo.git 2>err && {
> -	! git clone -c http.proxy=socks4://127.0.0.1/path https://example.com/repo.git 2>err && {
> -	! git bisect run ./fail.sh 2>err &&
> -	! git bisect run ./fail.sh 2>err &&

... simple cases in which the use of leading ! negation is the only issue with them, and if that is the reasoning, I think that is sensible. Contrasting these, many of the hits in t2206 (one among 14 hits in the above grep), for example, look like this:

  ! git status --porcelain | grep "^.*$" &&

which violates "do not hide exit status of git behind a pipe" rule, in addition to have a strange looking leading ! negation.

Will queue.
Previous: Hardik KumarNext: Hardik Kumar
Message 2 of 3 in “t: use test_must_fail instead of NOT operator”
  1. t: use test_must_fail instead of NOT operatorHardik Kumar, Nov 15, 2026
  2. Junio C HamanoNov 16, 2026
  3. Hardik KumarNov 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.