Re: [PATCH] abspath.c: use PATH_MAX in real_path_internal()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 18, 2014, 16:45 UTC
- Message-ID
- <xmqqbnsmobsq.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <53C85625.6020808@gmail.com>
Karsten Blees <karsten.blees@gmail.com> writes:
Show 6 quoted lines
> Am 17.07.2014 14:45, schrieb Nguyễn Thái Ngọc Duy: >> e.g. "git init". Make it static too to reduce stack usage. > > But wouldn't this increase overall memory usage? Stack memory > will be reused by subsequent code, while static memory cannot > be reused (but still increases the process working set).
Correct. And this is a function that is not involved in deep recursion, so avoiding stack allocation seems quite misguided.