Re: [PATCH] parse-options: detect attempt to add a duplicate short option name

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 3, 2014, 22:16 UTC
Message-ID: <xmqqbnqwwds2.fsf@gitster.dls.corp.google.com>
In-Reply-To: <54078C2C.5020503@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 8 quoted lines

>> It bugged me enough that we didn't identify which short option
>> letter we were complaining about
>
> The old code did report the short option.  E.g. for t1502 it said:
>
> 	error: BUG: switch 'b' short name already used
>
> You can leave that to optbug(), no need for the strbuf.

Not quite, as an opt with long name is reported with the long name only, which is not very nice when the problem we are reporting is about its short variant.

> Space is allowed as a short option by the code; intentionally?

I didn't think of a strong reason to declare either way, so, yes it was deliberate that I didn't tighten to disallow.