Re: [PATCH v6] send-email: Add sendmail email aliases format

From: Junio C Hamano <gitster@pobox.com>
Date: May 27, 2015, 20:08 UTC
Message-ID: <xmqqbnh5lr5k.fsf@gitster.dls.corp.google.com>
In-Reply-To: <950e3a77f09d62f77c9a40c843284b3686bdb7b0.1432675817.git.allenbh@gmail.com>

Allen Hubbe <allenbh@gmail.com> writes:

> Add support for the sendmail email aliases format.

Thanks.

>     ** Note: A general 'where to find documentation' paragraph will be added
>        by Junio, appearing either before or after this patch in the series.

You didn't have to do this to me; as long as you agree with me that the paragraph is a good thing to have, it is OK (and even more preferable) to include it in this patch.

That's called collaboration.

If other person's contribution was really significant and the change can stand on its own, then a split two-patch series with the author set to the other person may not be a bad idea, and if other person's contribution was really significant but the change by the other person cannot stand on its own, "Helped-by" in the log message would be sufficient. My contribution in this case is much less than that.

>     ** Note: A fix to other tests to eliminate the use of tilde for the home
>        dir will be added by Junio, appearing either before or after this
>        patch in the series.

That is a sensible thing to do, as it does not relate to this change.

Thanks. Will queue and let's start merging this topic to 'next' and down.