Re: [PATCH 2/2] send-email: allow multiple emails using --cc, --to and --bcc

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 2, 2015, 17:19 UTC
Message-ID: <xmqqbngy3u5e.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CA+V2YBvP89=b5SFbkUVnEzaPT2aCiK9XN1Hd6qsN8HCmxxB+GA@mail.gmail.com>

Rémi Lespinet <remi.lespinet@gmail.com> writes:

Show 14 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> The reason why we have the "verify the input" thing, allow users to
>> supply multiple --to/--cc/etc., and do not try to split the
>> addresses ourselves is because we want to avoid mistakenly splitting
>> a single address like the above into two and producing syntactically
>> incorrect addresses.  People have relied on the current behaviour
>> for a long time, without manually dropping comma when they send
>> their patches with --to='"Jane, Doe" <jdoe@example.com>'.
>
> Yes, but they couldn't send with --to='"Jane, Doe" <jdoe@example.com>'
> anyway since 79ee555b (Check and document the options to prevent
> mistakes. 2006-06-21).  So I don't think that this part is a
> regression.

Ahh, stupid me.  Thanks.

Then starting with the "split at the comma" implementation is perfectly fine. People will learn not to use '"Doe, Jane" <jdoe>' because that will not work while the implementation is limited, and later when it is enhanced, they can start using that form.