Re: What's cooking in git.git (Sep 2015, #02; Wed, 9)

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 10, 2015, 15:54 UTC
Message-ID: <xmqqbnda5kxp.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20150910092922.GB6633@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I did wonder if we needed to deal with any fallout from f4c3edc
> (vreportf: avoid intermediate buffer, 2015-08-11). That _is_ new in this
> release, so regressions are fair game during the -rc period.

Yeah, and the most obvious way to deal with it is just to revert, but as you point out, it is not really introducing a new issue, so there is not much point doing that, I would think.

> I don't think it should matter, though. Though it does add an fflush(), it
> is replacing an existing fprintf(), and both should be taking the same
> lock on stderr (so it probably _is_ still a potential problem, but not a
> new one).

Yeah, I reached the same conclusion.

Thanks.