git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bundle doc: 'verify' is not about verifying the bundle

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 2, 2016, 18:18 UTC
Message-ID
<xmqqbn6w4ubj.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160302092236.GB30065@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> On Tue, Mar 01, 2016 at 01:36:05PM -0800, Junio C Hamano wrote:
>
>> Even though the command does read the bundle header and checks to
>> see if it looks reasonable, the thin-pack data stream that follows
>> the header in the bundle file is not checked.  More importantly,
>> because the thin-pack data does not have a trailing checksum like
>> on-disk packfiles do, there isn't much "verification" the command
>> can do without unpacking the objects from the stream even if it
>> wanted to.
>
> Are you sure about that trailing checksum thing?

No. I misread the fact that we do not say the final csum on the command output from pack-objects in the --stdout case. We do call the sha1close() to append the csum at the end of the pack stream; we just do not make it available to the caller who is driving the pack-object procedure.

Previous: Jeff King
Message 4 of 4 in “bundle doc: 'verify' is not about verifying the bundle”
  1. bundle doc: 'verify' is not about verifying the bundleJunio C Hamano, Mar 1, 2016
  2. Philip OakleyMar 1, 2016
  3. Jeff KingMar 2, 2016
  4. Junio C HamanoMar 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.