Re: weird diff output?

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 30, 2016, 00:04 UTC
Message-ID: <xmqqbn5wvnix.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+P7+xoLZhKzHf6khQfT_pZ2=CQAp8Nmhc9B8+10+9=YYUZH3w@mail.gmail.com>

Jacob Keller <jacob.keller@gmail.com> writes:

Show 10 quoted lines

> On Tue, Mar 29, 2016 at 11:16 AM, Stefan Beller <sbeller@google.com> wrote:
>> ...
>> To find a heuristic, which appeals both the C code
>> and the shell code, we could take the empty line
>> as a strong hint for the divider:
>
> This seems like a good heuristic. Can we think of any examples where
> it would produce wildly confusing diffs? I don't think it necessarily
> needs to be default but just a possible option when formatting diffs,
> much like we already have today.

I earlier said "50% of the time it is correct, you just do not remember", but such an option with configuration variable would let somebody interested set it permanently for his daily use of Git, and it would help him to find out (1) if he sees a "Huh?" division less (or more) often than he used to, and (2) if it gives a better division for the same change to view the diff with the plain-vanilla heuristic.