Re: [PATCH] pathspec: remove check_path_for_gitlink
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 5, 2016, 23:09 UTC
- Message-ID
- <xmqqbn4k85lm.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1462487497-28394-1-git-send-email-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 24 quoted lines
> `check_path_for_gitlink` was introduced in 9d67b61f739a (2013-01-06, > add.c: extract check_path_for_gitlink() from treat_gitlinks() for reuse) > but the implementation was removed in 5a76aff1a6 (2013-07-14, add: > convert to use parse_pathspec). > > Remove the declaration from the header as well. > > Signed-off-by: Stefan Beller <sbeller@google.com> > --- > pathspec.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/pathspec.h b/pathspec.h > index 0c11262..b596aed 100644 > --- a/pathspec.h > +++ b/pathspec.h > @@ -96,7 +96,6 @@ static inline int ps_strcmp(const struct pathspec_item *item, > > extern char *find_pathspecs_matching_against_index(const struct pathspec *pathspec); > extern void add_pathspec_matches_against_index(const struct pathspec *pathspec, char *seen); > -extern const char *check_path_for_gitlink(const char *path); > extern void die_if_path_beyond_symlink(const char *path, const char *prefix); > > #endif /* PATHSPEC_H */
Interesting.
I wonder if the patches mentioned have something to do with the "git add deep/in/the/tree" that fails to notice deep/in/ is an unrelated repository in some way?