Re: [PATCH v7 6/7] submodule: refactor show_submodule_summary with helper function

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 18, 2016, 20:49 UTC
Message-ID: <xmqqbn0p6bvu.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+P7+xqQ-iaax3rtZbsGb6D4vBbwP7d63Qq4D2_z71V0Z4YCeg@mail.gmail.com>

Jacob Keller <jacob.keller@gmail.com> writes:

Show 14 quoted lines

>>>> If we were to change those, we could discuss if we want to go with
>>>> full sentences
>>>> all the time:
>>>>
>>>>     submodule is new
>>>>     submodule is deleted
>>>>     submodule is not initialized
>>>
>>> I agree, I'll make a new patch that does this as a cleanup prior to
>>> this re-work.
>> ...
> Sorry for being unclear myself, too. I'm keeping it as "not
> initialized" and updating the description of the patch that changed it
> from "not checked out" to "not initialized"

Whether it is done inside or outside the scope of this series, the other two "is new"/"is deleted" updates look very sensible ones to make in the longer run. I'd further suggest to unify "commits not present" and "revision walker failed" into one error class. From the end user's point of view, they aren't very different.