Re: [PATCH v3 2/3] refs: add option core.logAllRefUpdates = always
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 31, 2017, 17:08 UTC
- Message-ID
- <xmqqbmunrwbf.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170130233702.o6naszpz32juf5gt@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> So I agree the current behavior is quietly broken, which is not good. > But I wonder if "--no-create-reflog" is really sane in the first place, > and whether we might be better off to simply disallow it.
Thanks for a reasoned argument and a reasonable justification. I agree with all that.
I think it is probably a good idea to document the behaviour (i.e. "--no-create" single-shot from the command line is ignored). I am not sure we should error out, though, in order to "disallow" it---a documented silent no-op may be sufficient.