Re: [PATCH] name-rev: change ULONG_MAX to TIME_MAX

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 6, 2017, 03:35 UTC
Message-ID: <xmqqbmmo8pp6.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <ef9aebb63227c36b8b72a65240a416a0271cc618.1504086318.git.git@grubix.eu>

Michael J Gruber <git@grubix.eu> writes:

Show 12 quoted lines

> Earlier, dddbad728c ("timestamp_t: a new data type for timestamps",
> 2017-04-26) changed several types to timestamp_t.
>
> 5589e87fd8 ("name-rev: change a "long" variable to timestamp_t",
> 2017-05-20) cleaned up a missed variable, but both missed a _MAX
> constant.
>
> Change the remaining constant to the one appropriate for the current
> type
>
> Signed-off-by: Michael J Gruber <git@grubix.eu>
> ---

Thanks.

I think this (and the earlier 5589e8) was caused by an unnoticed semantic conflict at 78089b71 ("Merge branch 'jc/name-rev-lw-tag'", 2017-05-30). Merging is sometimes hard ;-)

Will queue.

Show 16 quoted lines

>  builtin/name-rev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/name-rev.c b/builtin/name-rev.c
> index c41ea7c2a6..598da6c8bc 100644
> --- a/builtin/name-rev.c
> +++ b/builtin/name-rev.c
> @@ -253,7 +253,7 @@ static int name_ref(const char *path, const struct object_id *oid, int flags, vo
>  		struct commit *commit = (struct commit *)o;
>  		int from_tag = starts_with(path, "refs/tags/");
>  
> -		if (taggerdate == ULONG_MAX)
> +		if (taggerdate == TIME_MAX)
>  			taggerdate = ((struct commit *)o)->date;
>  		path = name_ref_abbrev(path, can_abbreviate_output);
>  		name_rev(commit, xstrdup(path), taggerdate, 0, 0,