Re: [PATCH] doc/read-tree: remove obsolete remark
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 11, 2018, 19:02 UTC
- Message-ID
- <xmqqbmi0z0b7.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20180111104914.GA5897@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 20 quoted lines
> On Tue, Jan 09, 2018 at 04:30:34PM +0100, Andreas G. Schacker wrote: > >> Earlier versions of `git read-tree` required the `--prefix` option value >> to end with a slash. This restriction was eventually lifted without a >> corresponding amendment to the documentation. > > Makes sense. > >> ---prefix=<prefix>/:: >> +--prefix=<prefix>:: >> Keep the current index contents, and read the contents >> of the named tree-ish under the directory at `<prefix>`. >> The command will refuse to overwrite entries that already >> - existed in the original index file. Note that the `<prefix>/` >> - value must end with a slash. >> + existed in the original index file. > > Is it worth mentioning in the new world order that the slash is not > implied? I.e., that you probably do want to say "--prefix=foo/" if you > want the subdirectory "foo", but do not want to match "foobar"?
Doesn't "git read-tree --prefix=previous HEAD^" add paths like "previous/Documentation/Makefile" to the index, i.e. instead of forcing you to have the required slash at the end, we give one for free when it is missing?