Re: [PATCH 6/8] gpg-interface: find the last gpg signature line

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2018, 21:04 UTC
Message-ID: <xmqqbmeq3h8o.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAE=pOyFj+WZBB6Zp35d=mYNsxcJK-LwOxseWXSmY_hs+Lwugpg@mail.gmail.com>

Ben Toews <mastahyeti@gmail.com> writes:

Show 21 quoted lines

>> Hmmmm, what vintage of our codebase is this patch based on?  Did I
>> miss a patch that removes these lines
>>
>>
>>     printf '      ' >sigblanknonlfile
>>     get_tag_header blanknonlfile-signed-tag $commit commit $time >expect
>>     echo '-----BEGIN PGP SIGNATURE-----' >>expect
>>     test_expect_success GPG \
>>             'creating a signed tag with spaces and no newline should succeed' '
>>             git tag -s -F sigblanknonlfile blanknonlfile-signed-tag &&
>>             get_tag_msg blanknonlfile-signed-tag >actual &&
>>             test_cmp expect actual &&
>>             git tag -v signed-tag
>>     '
>>
>> which appear between the pre- and post- context of the lines you are
>> inserting?  They date back to 2007-2009.
>>
>
> That test was fixed a week ago:
> https://github.com/git/git/commit/a99d903f21d102a5768f19157085a9733aeb68dd

Well, you cannot expect any reviewer to know about a change that has never been sent to the list and has never been part of even 'pu' branch, no matter how old such a private "fix" is.

What other unpublished things that are not even on 'pu' do these patches depend on?