Re: [PATCH] repository: fix free problem with repo_clear(the_repository)

From: Junio C Hamano <gitster@pobox.com>
Date: May 10, 2018, 09:27 UTC
Message-ID: <xmqqbmdnkgh4.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAGZ79kbFiULj1NJARm6ObYrqv_Fu+U2sb8h_sNJwdWur+JqrvQ@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 12 quoted lines

> So this would go with the latest sb/object-store-alloc ?
>
> My impression was that we never call repo_clear() on
> the_repository, which would allow us to special case
> the_repository further just as I did in v2 of that series[1] by
> having static allocations for certain objects in case of \
> the_repository.
>
> [1] https://public-inbox.org/git/20180501213403.14643-14-sbeller@google.com/
>
> We could just deal with all the exceptions, but that makes repo_clear
> ugly IMHO.

So perhaps

         void repo_clear(...)
         {
        +       if (repo == the_repository)
        +               BUG("repo_clear() called on the repository");
                ...

or something?