Re: [PATCH 2/1] SubmittingPatches: not git-security@googlegroups.com
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 28, 2018, 03:00 UTC
- Message-ID
- <xmqqbmd0lc11.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180527210822.GB8868@hank.intra.tgummerer.com>
Thomas Gummerer <t.gummerer@gmail.com> writes:
Show 8 quoted lines
> Yeah sorry, that's what I meant. > https://public-inbox.org/git/20180308150820.22588-1-avarab@gmail.com/ > is the reference I meant to put there. > > How about something like the below? This is tested with asciidoc > 8.6.10 and asciidoctor 1.5.6.2. I'm also happy to squash the two > patches into one if that's preferred. >
If the discussion in the proposed log message needs to be updated anyway, it is a good opportunity to make them into a single patch, as they share exactly the same objective.
This is a tangent, but the use of footnote below looks a but curious. How would {1} reference pick which :1: to use? The closest preceding one?
As this appears on a page that already has other footnotes attached to an adjacent paragraph, I am wondering if they should be made into a part of the same numbering sequence.
Show 11 quoted lines
> @@ -264,6 +264,11 @@ people who are involved in the area you are touching (the `git
> contacts` command in `contrib/contacts/` can help to
> identify them), to solicit comments and reviews.
>
> +:1: footnote:[The Git Security mailing list: git-security@googlegroups.com]
> +
> +Patches which are security relevant should be submitted privately to
> +the Git Security mailing list{1}.
> +
> :1: footnote:[The current maintainer: gitster@pobox.com]
> :2: footnote:[The mailing list: git@vger.kernel.org]Also, the placement of this new paragraph is rather odd.
I am guessing that the reason why you put it _before_ the normal list address is to make sure those with secrets that must be guarded won't send it to the list first without thinking, but then this place is too late for that, as the previous paragraph already told the reader that the patch should be sent to the list and others but not necessarily to the maintainer. This should go one paragraph before that, at least. I briefly considered suggesting to move it even earlier, e.g. the beginning of "Sending your patches" section, but then by the time readers with potential security patches may have forgotten it, or worse, get confused by us, when we say "Send your patches with To: set to the list". So I dunno. The most conservative would be to write it at the beginning of the section and then repeat it just before "Send to the list, Cc releavant people" paragraph as a reminder.