Re: [PATCHv3 1/5] t7406: simplify by using diff --name-only instead of diff --raw

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 7, 2018, 18:18 UTC
Message-ID: <xmqqbmaekpke.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CABPp-BGB5dD6UYUzRq2pDSan-2CV7=8xmZKCa0tv7nzY2Mb-aA@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 5 quoted lines

>> I think 0/5 should fix the real bug you are deliberately keeping in
>> this patch, from the point of view of organization.
>
> You mean 5/5?  And yeah, it was just a temporary thing for
> organizational purposes.

I meant "a thing that comes before all the other steps".

As far as I can tell, everything else this 5-patch series improves would still have caught a new bug in the subsystem being tested (i.e. "submodule update") even without these improvements. Surely, if we greak "git diff", "git diff --raw" that sits on the upstream of a pipe would not have stopped these tests, but we have tests for "diff" elsewhere and t7406 are not about catching the breakage of "diff", so from that point of view, fixing them, although it is necessary and important, is less important.

The "\| grep" thing was a real bug in that if we broke "submodule update", it would not have helped to catch such a bug, as it wasn't looking for 'submodule' string in the output.

That is why I felt it would have been a better organization to fix "\| grep" in "a thing that comes before all the other steps" and then fix the rest as lower priority clean up.