Re: [PATCH] worktree: refactor lock_reason_valid and lock_reason to be more sensible

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 29, 2018, 06:42 UTC
Message-ID: <xmqqbm7d45k8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAC05386YPtB5LmHFq3WrAaZ1vmZaBUdGr9hEbyR8KABzj+CzZQ@mail.gmail.com>

Nickolai Belakovski <nbelakovski@gmail.com> writes:

> Either way, I do see an issue with the current code that anybody who
> wants to know the lock status and/or lock reason of a worktree gets
> faced with a confusing, misleading, and opaque piece of code.

Sorry, I don't. I do not mind a better documentation for is_worktree_locked() without doing anything else.

I do not see any reason to remove fields, split the helper funciton into two, drop the caching, etc., especially when the only justification is "I am new to the codebase and find it confusing".