Re: [PATCH v2 1/1] remote-curl.c: xcurl_off_t is not portable (on 32 bit platfoms)

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 12, 2018, 03:50 UTC
Message-ID: <xmqqbm6v3qex.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181109174110.27630-1-tboegi@web.de>

tboegi@web.de writes:

Show 5 quoted lines

>
> This is a re-semd, the orignal patch was part of a 2
> patch-series.
> This patch needed some rework, and here should be
> the polished version.

Will queue. Next time, please refrain from saying "re-send", if you changed anything in the patch (or the log message), as the phrase implies you are sending the same thing as before (just in case the earlier one was not seen, for example). Marking it as vN+1 like you did for this patch and having a reference to the original would make it clear, though ;-)

Thanks.

Show 22 quoted lines

> remote-curl.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/remote-curl.c b/remote-curl.c
> index 762a55a75f..1220dffcdc 100644
> --- a/remote-curl.c
> +++ b/remote-curl.c
> @@ -617,10 +617,11 @@ static int probe_rpc(struct rpc_state *rpc, struct slot_results *results)
>  	return err;
>  }
>  
> -static curl_off_t xcurl_off_t(ssize_t len) {
> -	if (len > maximum_signed_value_of_type(curl_off_t))
> +static curl_off_t xcurl_off_t(size_t len) {
> +	uintmax_t size = len;
> +	if (size > maximum_signed_value_of_type(curl_off_t))
>  		die("cannot handle pushes this big");
> -	return (curl_off_t) len;
> +	return (curl_off_t)size;
>  }
>  
>  static int post_rpc(struct rpc_state *rpc)