git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 1/4] transport-helper: use xread instead of read

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 2, 2019, 20:55 UTC
Message-ID
<xmqqbm4ykcdk.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181228233556.5704-1-randall.s.becker@rogers.com>
randall.s.becker@rogers.com writes:
Show 5 quoted lines
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> This fix was needed on HPE NonStop NSE and NSX where SSIZE_MAX is less than
> BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c
> was the only place outside of wrapper.c where it is used instead of xread.
Thanks.
Show 19 quoted lines
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
>  transport-helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/transport-helper.c b/transport-helper.c
> index bf225c698f..a290695a12 100644
> --- a/transport-helper.c
> +++ b/transport-helper.c
> @@ -1225,7 +1225,7 @@ static int udt_do_read(struct unidirectional_transfer *t)
>  		return 0;	/* No space for more. */
>  
>  	transfer_debug("%s is readable", t->src_name);
> -	bytes = read(t->src, t->buf + t->bufuse, BUFFERSIZE - t->bufuse);
> +	bytes = xread(t->src, t->buf + t->bufuse, BUFFERSIZE - t->bufuse);
> - 	if (bytes < 0 && errno != EWOULDBLOCK && errno != EAGAIN &&
> - 		errno != EINTR) {
> + 	if (bytes < 0 && errno != EINTR) {
>  		error_errno(_("read(%s) failed"), t->src_name);

Can't we also lose EINTR check, though? When read() returns negative, we check errno and if it is EINTR, continue the loop.

Previous: randall.s.becker@rogers.comNext: Jeff King
Message 2 of 4 in “transport-helper: use xread instead of read”
  1. 1/4 transport-helper: use xread instead of readrandall.s.becker@rogers.com, Dec 28, 2018
  2. Junio C HamanoJan 2, 2019
  3. Jeff KingJan 3, 2019
  4. Junio C HamanoJan 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.