Re: [PATCH] http: don't leak urlmatch_config.vars
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 26, 2019, 18:09 UTC
- Message-ID
- <xmqqblwbhk7f.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190826074911.23792-1-mh@glandium.org>
Mike Hommey <mh@glandium.org> writes:
> Signed-off-by: Mike Hommey <mh@glandium.org> > --- > http.c | 1 + > 1 file changed, 1 insertion(+)
This matches what builtin/config.c::get_urlmatch() does, which makes sense.
Thanks.
Show 13 quoted lines
>
> diff --git a/http.c b/http.c
> index 27aa0a3192..9e33584f2d 100644
> --- a/http.c
> +++ b/http.c
> @@ -1073,6 +1073,7 @@ void http_init(struct remote *remote, const char *url, int proactive_auth)
>
> git_config(urlmatch_config_entry, &config);
> free(normalized_url);
> + string_list_clear(&config.vars, 1);
>
> #if LIBCURL_VERSION_NUM >= 0x073800
> if (http_ssl_backend) {