Re: [PATCH 1/1] fix-typo: consecutive-word duplications

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 5, 2019, 14:13 UTC
Message-ID: <xmqqblsm273m.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <abb9e55ad5ef72242ee97e03316827b55ef2f4c8.1575517503.git.gitgitgadget@gmail.com>

"ryenus via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: ryenus <ryenus@gmail.com>
>
> Correct unintentional duplication(s) of words, such as "the the",
> and "can can" etc.

Understood.

I would rather honor the original when it is not clearly wrong, misleading to readers or prone to misunderstanding. Hence, I'd rather not change this particular one.

> "we didn't do so so far" becomes "we didn't do that so far".

And also this one.

>   * This should use the pathname to decide on whether it wants to do some
>   * more interesting conversions (automatic gzip/unzip, general format
> - * conversions etc etc), but by default it just does automatic CRLF<->LF
> + * conversions etc), but by default it just does automatic CRLF<->LF

Everything else in this patch is improving what is clearly wrong and is very much appreciated, though.

Just a reminder, as I do not know your cultural background so ryenus in all lowercase may be your real name, in which case please ignore this part of the response, but Documentation/SubmittingPatches says

    [[real-name]]
    Also notice that a real name is used in the Signed-off-by: line. Please
    don't hide your real name.

about the Signed-off-by: line.

Thanks.