git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] run-command.c: ensure signaled hook scripts are waited upon

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 22, 2020, 17:12 UTC
Message-ID
<xmqqblpq7dho.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20200221063954.GJ1280313@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> If we assume that most people would prefer this "wait until the hook has
> died" behavior, I think this shouldn't have any unwanted secondary
> effects. I'm on the fence on whether it's what most people would want or
> not (I guess most people don't care either way, because their scripts
> don't ignore SIGINT).

Yeah, and imagining why they deliberately ignore INT (i.e. "because I want this hook not be interrupted and run to its completion") does not help guess if they want git to wait for hook's completion or just go ahead and die of its own signal death. We could timeout the waiting and kill such a child forcibly, and that may avoid these hook script that ignore INT to hang around, but I do not know if that is desirable.

Previous: Jeff King
Message 3 of 3 in “run-command.c: ensure signaled hook scripts are waited upon”
  1. run-command.c: ensure signaled hook scripts are waited uponAnthony Sottile, Feb 21, 2020
  2. Jeff KingFeb 21, 2020
  3. Junio C HamanoFeb 22, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.