Re: [PATCH] Doc: reference 'seen' instead of 'pu' in meta docs

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 23, 2020, 22:51 UTC
Message-ID: <xmqqbll9bdki.fsf@gitster.c.googlers.com>
In-Reply-To: <20200623152207.GA2027104@generichostname>

Denton Liu <liu.denton@gmail.com> writes:

Show 26 quoted lines

> Hi Dscho,
>
> On Tue, Jun 23, 2020 at 05:09:12PM +0200, Johannes Schindelin wrote:
>> Hi Denton,
>> 
>> On Tue, 23 Jun 2020, Denton Liu wrote:
>> 
>> > As of 2020-06-22, the name of git.git's integration branch has been
>> > renamed from 'pu' to 'seen'.[0] Update git.git-specific documentation to
>> > refer to the new branch name. In particular, update documents that refer
>> > to the workflow and also "how to contribute"-type docs.
>> >
>> > There still remains other uses of 'pu' in the docs. In these cases, it
>> > is generally used as an example and there isn't much value in updating
>> > these examples since they aren't git.git specific.
>> >
>> > [0]: https://lore.kernel.org/git/xmqqimfid2l1.fsf@gitster.c.googlers.com/
>> 
>> Whoops, I only saw this now. In the meantime I submitted what I hope is a
>> more complete version of this patch.
>
>  No worries. I was on the fence about changing any non-meta
>  documentation but, after reading your justification for the patches, it
>  makes sense to me. Let's supersede my version with yours. 
>
>  -Denton

The differences are quite small and there are only three differences to the paths touched by this patch vs Dscho's. Two of them are "(patches seen by ...)" that explains what `seen` is, which is a good reason to keep Dscho's version.

The change to Documentation/SubmittingPatches in your version quotes `seen` better that matches how `git pull --rebase` nearby is quoted, which Dscho may want to mimick in his version, though.

Thanks, both.