Re: [PATCH] Propagate --quiet on submodule update to merge/rebase
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 30, 2020, 20:34 UTC
- Message-ID
- <xmqqblhngg1s.fsf@gitster.c.googlers.com>
- In-Reply-To
- <F2F35572-E88F-4D6F-844B-6E17FCFD2175@google.com>
Theodore Dubois <tbodt@google.com> writes:
Show 9 quoted lines
>> This is not the problem this patch introduces, but the way GIT_QUIET >> variable is set up does not allow us to do the above so nicely, I >> suspect. Wouldn't the above change make "git submodule update -v" >> invoke the underlying commands with "--quiet" option? > > Interesting. I didn't check every setting of GIT_QUIET, just > looked at the first few and assumed the rest would be the > same. The "git submodule--helper update-clone" invocation also has > this problem. I'll resend with "unset GIT_QUIET".
It seems set_branch also is written with a strange sense of humor. It pays attention to GIT_QUIET but never sets it itself.
Thanks.