Re: [PATCH 0/2] midx: prevent against racily disappearing packs

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 25, 2020, 21:13 UTC
Message-ID: <xmqqblfldts4.fsf@gitster.c.googlers.com>
In-Reply-To: <cover.1606324509.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

> Here are a couple of patches that Peff and I wrote after noticing a
> problem where racily disappearing .idx files can cause a segfault. While
> investigating, we fixed a related issue which is described and fixed in
> the second patch.

In the cover letter it won't affect the end result, but when talking about "race", it always is a good idea to explicitly mention both sides of the race. It is clear what one side is in the above (i.e. somebody who removes .idx file that is still in use), but it is not so clear who gets hit and segfaults.

I am guessing that the other party is the user of .pack file(s) bypassing the corresponding .idx file(s) because the necessary data is mostly in .midx?

Thanks.