git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] stash show: don't setup default diff output format if --{include,only}-untracked given

From
Junio C Hamano <gitster@pobox.com>
Date
May 19, 2021, 22:17 UTC
Message-ID
<xmqqbl96xt9q.fsf@gitster.g>
In-Reply-To
<YKTZIOOe+IW41MXp@generichostname>
Denton Liu <liu.denton@gmail.com> writes:
> I could be convinced either way and I was erring on the side of caution
> by proposing this patch. I'm okay with the status quo so we can keep the
> behaviour as is, unless someone objects in which case we should revert
> pending more discussion.

I do not know if "--stat" is a good default for "git stash show", with or without "-u", to begin with, but if the default varies between "git stash show" and "git stash show -u", it would be like "git diff" and "git diff HEAD" using different defaults depending on what is being compared. And from that point of view, I did find that the patch takes the behaviour in a less consistent and more confusing direction.

> I'll send a follow-up patch later this week clarifying the docs.
Thanks.
Previous: Denton Liu
Message 4 of 4 in “stash show: don't setup default diff output format if --{include,only}-untracked given”
  1. stash show: don't setup default diff output format if --{include,only}-untracked givenDenton Liu, May 18, 2021
  2. Junio C HamanoMay 19, 2021
  3. Denton LiuMay 19, 2021
  4. Junio C HamanoMay 19, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.