Re: [PATCH v2] commit: restore --edit when combined with --fixup

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 12, 2021, 19:51 UTC
Message-ID: <xmqqbl6230i1.fsf@gitster.g>
In-Reply-To: <873ec1ab-c062-4306-b3fb-09d32c70cc7f@www.fastmail.com>

"Joel Klinghed" <the_jk@spawned.biz> writes:

Show 12 quoted lines

>> Writing this as
>> 
>> 			if (edit_flag < 0)
>> 
>> makes it far easier to immediately see that we are talking about a
>> nagetive edit_flag.
>> 
>
> Agree, I'll change it.
> I was unsure of the style and copied from the earlier condition:
> 	if (0 <= edit_flag)
> 		use_editor = edit_flag;

There are two valid schools of thought when it comes to comparison.

Some folks consider that a comparison between a variable and a constant is a statement about the variable, hence the expression should be

		if (VARIRABLE comparison-operator CONSTANT)

They will write things like:

		if (edit_flag >= 0)
		if (edit_flag < 0)

Other folks consider that textual order of the comparison should match the actual order of the things being compared, as if they are arranged on a number line, hence the expression should be

		if (SMALLER < LARGER)

no matter which one is variable and which one is constant.

They will write:

		if (0 <= edit_flag)
		if (edit_flag < 0)

The case in question, asserting that edit_flag is negative, is what both camps agree how to write.