Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 1, 2021, 14:55 UTC
Message-ID: <xmqqbl5cs5v9.fsf@gitster.g>
In-Reply-To: <20210831220208.3924051-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 17 quoted lines

>> * ka/want-ref-in-namespace (2021-08-13) 3 commits
>>  - docs: clarify the interaction of transfer.hideRefs and namespaces
>>  - upload-pack.c: treat want-ref relative to namespace
>>  - t5730: introduce fetch command helper
>> 
>>  "git upload-pack" which runs on the other side of "git fetch"
>>  forgot to take the ref namespaces into account when handling
>>  want-ref requests.
>
> Sorry for not being able to look at this until now, but:
>
> Reviewed-by: Jonathan Tan <jonathantanmy@google.com>
>
> Thanks for addressing my comment about the failing tests to be written
> in success/failure pairs [1] - I see that that has been done in patch 2.
>
> [1] https://lore.kernel.org/git/20210802210644.3432544-1-jonathantanmy@google.com/

Thanks. Will "rebase -i (reword)" your Reviewed-by in and then advance the topic to 'next'.