Re: [PATCH 2/2] gpg-interface: avoid buffer overrun in parse_ssh_output()

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 1, 2021, 17:44 UTC
Message-ID: <xmqqbl33db3a.fsf@gitster.g>
In-Reply-To: <d758381f-064a-1d0a-afab-cb2160ea2eec@gigacodes.de>

Fabian Stelzer <fs@gigacodes.de> writes:

Show 13 quoted lines

> On 30.10.21 19:07, René Scharfe wrote:
>> If the string "key" we found in the output of ssh-keygen happens to be
>> located at the very end of the line, then going four characters further
>> leaves us beyond the end of the string.  Explicitly search for the
>> space after "key" to handle a missing one gracefully.
>> 
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>> ---
>> This code was added after v2.33.0.
>> 
>> 
>
> Thanks. This is obviously correct.

Thanks, both.  Will apply.