git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/1] xdiff: provide indirection to git functions

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 25, 2022, 18:58 UTC
Message-ID
<xmqqbkyudb8n.fsf@gitster.g>
In-Reply-To
<20220225183854.GA9@811aa366e12e>
Edward Thomson <ethomson@edwardthomson.com> writes:
> No, the thinking is that they would provide their own `git-xdiff.h` that
> defines the mappings to their project-specific APIs.

Is that spelled out somewhere? That would help future readers of the file to learn what they need to do when reusing the part, perhaps in a comment near the top of that file itself.

If git-xdiff.h is meant to be modified to match the need for non-git codebase, it probably should be named to a more descriptive name, like xdiff-compat.h or something, I would think. git-xdiff.h that has libgit2 specific names in it would look quite strange.

Previous: Edward ThomsonNext: Junio C Hamano
Message 7 of 8 in “xdiff: provide indirection to git functions”
  1. 0/1 xdiff: provide indirection to git functionsEdward Thomson, Feb 17, 2022
  2. 1/1 xdiff: provide indirection to git functionsEdward Thomson, Feb 17, 2022
  3. Phillip WoodFeb 22, 2022
  4. Johannes SchindelinFeb 25, 2022
  5. Junio C HamanoFeb 25, 2022
  6. Edward ThomsonFeb 25, 2022
  7. Junio C HamanoFeb 25, 2022
  8. Junio C HamanoFeb 25, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.