Re: [PATCH v3 6/9] Makefile: move $(comma), $(empty) and $(space) to shared.mak

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 25, 2022, 23:24 UTC
Message-ID: <xmqqbkyu8r7t.fsf@gitster.g>
In-Reply-To: <patch-v3-6.9-1b6ecb27f02-20220225T090127Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Move these variables over to the shared.max, we'll make use of them in

max?

> a subsequent commit. There was no reason for these to be "simply
> expanded variables", so let's use the normal lazy "=" assignment here.

Seems to do unrelated things "while at it" which is a common pattern that slows the reviews down.

Show 16 quoted lines

> diff --git a/shared.mak b/shared.mak
> index 1dda948df09..f6b589ffd8f 100644
> --- a/shared.mak
> +++ b/shared.mak
> @@ -23,3 +23,11 @@
>  #
>  #    info make --index-search=.DELETE_ON_ERROR
>  .DELETE_ON_ERROR:
> +
> +### Global variables
> +
> +## comma, empty, space: handy variables as these tokens are either
> +## special or can be hard to spot among other Makefile syntax.
> +comma = ,
> +empty =
> +space = $(empty) $(empty)

In any case, wanting to have a $(space) is not specific to the top-level Makefile, and it is a good idea to move them to the shared file.