Re: What's cooking in git.git (Mar 2022, #06; Mon, 28)

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2022, 23:08 UTC
Message-ID: <xmqqbkxoqrvd.fsf@gitster.g>
In-Reply-To: <20220329225106.GA12169@neerajsi-x1.localdomain>

Neeraj Singh <nksingh85@gmail.com> writes:

Show 27 quoted lines

> On Mon, Mar 28, 2022 at 07:22:47PM -0700, Junio C Hamano wrote:
>> 
>> * ns/core-fsyncmethod (2022-03-15) 6 commits
>>   (merged to 'next' on 2022-03-17 at c8a52f8cbe)
>>  + core.fsync: documentation and user-friendly aggregate options
>>  + core.fsync: new option to harden the index
>>  + core.fsync: add configuration parsing
>>  + core.fsync: introduce granular fsync control infrastructure
>>  + core.fsyncmethod: add writeout-only mode
>>  + wrapper: make inclusion of Windows csprng header tightly scoped
>>  (this branch is used by ns/batch-fsync and ps/fsync-refs.)
>> 
>>  Replace core.fsyncObjectFiles with two new configuration variables,
>>  core.fsync and core.fsyncMethod.
>>  source: <pull.1093.v6.git.1646952204.gitgitgadget@gmail.com>
>> 
>
> There's a fix for this series at:
> https://lore.kernel.org/git/pull.1191.git.1648590113062.gitgitgadget@gmail.com/
> <pull.1191.git.1648590113062.gitgitgadget@gmail.com>
>
> The net effect of the bug being fixed is that anyone using the default
> core.fsync config is syncing everything except loose objects.
>
> Apologies for the bug. I noticed it when revising the perf tests and
> debugging the number of fsyncs. I'm submitting a separate patch to
> log fsync info through trace2.

Thanks.  We should have caught it during the review.

Queued.