Re: [PATCH v2 1/1] contrib/vscode/: debugging with VS Code and gdb

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 6, 2022, 20:23 UTC
Message-ID: <xmqqbkxex8oy.fsf@gitster.g>
In-Reply-To: <378c5790-f587-4e26-87be-8f856974e5ca@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 12 quoted lines

>  
>> Signed-off-by: COGONI Guillaume <cogoni.guillaume@gmail.com>
>> Co-authored-by: BRESSAT Jonathan <git.jonathan.bressat@gmail.com>
>> Helped-by: Matthieu Moy <Matthieu.Moy@univ-lyon1.fr>
>> Helped-by: Derrick Stolee <derrickstolee@github.com>
>
> Here, you probably want to flip the order here (Helped-by, then
> Co-authored-by, then Signed-off-by). You probably also want the
> sign-off of your co-author, too.
>
> The sign-off should be the last thing in the message, because
> the previous lines are covered by that sign-off.

Yup. It would record the order of events that lead to this exact patch, which is what we want to capture. With help by these people, together with the co-author(s), the patch was written and author(s) signed-off before it was sent out to the list.

> ...
> And this is the necessary fix.
>
> Thanks for working on this!

Indeed.  And thanks for a helpful review.