Re: [PATCH v3 5/7] builtin: patch-id: add --include-whitespace as a command mode

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 14, 2022, 21:24 UTC
Message-ID: <xmqqbkqe6qv4.fsf@gitster.g>
In-Reply-To: <bbaa2425ad0cbb4b945cdce3402c6ed5fab381ec.1665737804.git.gitgitgadget@gmail.com>

"Jerry Zhang via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> +--include-whitespace::
> +	Use the "stable" algorithm described below and also don't strip whitespace
> +	from lines when calculating the patch-id.
> +
> +	This is the default if patchid.includeWhitespace is true and implies
> +	patchid.stable.

This seems very much orthogonal to "--stable/--unstable.

Because the "--stable" variant is more expensive than "--unstable", I am not sure why such an implication is a good thing to have. Why can we not have

    --include-whitespace --stable
    --include-whitespace --unstable

both combinations valid?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.