Re: [GSoC][PATCH] builtin/clean.c: fix error message usage typo

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 14, 2023, 05:32 UTC
Message-ID: <xmqqbklw95in.fsf@gitster.g>
In-Reply-To: <20230214032534.507628-1-cheskaqiqi@gmail.com>

Shuqi Liang <cheskaqiqi@gmail.com> writes:

> As Documentation/CodingGuidelines says, we shouldn't capitalize the first
> word in error message. Change the capital letter to lowercase letter.

I think the "do not caplitalize" rule is about the sentence after "fatal:", "error:", "warning:", and "info:" labels.

Show 6 quoted lines

> -static const char *msg_remove = N_("Removing %s\n");
> -static const char *msg_would_remove = N_("Would remove %s\n");
> -static const char *msg_skip_git_dir = N_("Skipping repository %s\n");
> -static const char *msg_would_skip_git_dir = N_("Would skip repository %s\n");
> -static const char *msg_skip_cwd = N_("Refusing to remove current working directory\n");
> -static const char *msg_would_skip_cwd = N_("Would refuse to remove current working directory\n");

Do any of these messages come after any of these labels? I didn't think so.

>  static const char *msg_warn_remove_failed = N_("failed to remove %s");
>  static const char *msg_warn_lstat_failed = N_("could not lstat %s\n");

These do appear after "warning:" and downcasing is very much appropriate.

Thanks.