git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] gitk: handle long command-lines

From
Junio C Hamano <gitster@pobox.com>
Date
May 8, 2023, 17:53 UTC
Message-ID
<xmqqbkiupv4m.fsf@gitster.g>
In-Reply-To
<fce603aa-ceb7-d601-6a19-657e36d9059c@iee.email>
Philip Oakley <philipoakley@iee.email> writes:
Show 16 quoted lines
> On 27/03/2023 10:17, Johannes Schindelin wrote:
>> Hi Pau & Junio,
>>
>> this patch series saw a positive review from Junio (thank you! I know that
>> you try to stay away from Tcl code, so I appreciate the effort very much),
>> but apart from that it simply languished on the mailing list for more than
>> two months now.
>>
>> Paul, is there anything I can do to help you integrate this into `gitk`?
>> Or is it time to pass over `gitk` maintenance to the Git project?
>>
>> Ciao,
>> Johannes
>
> I just tripped over this problem while trying to de-stack my Git backlog
> https://github.com/git-for-windows/git/issues/4408 "sdk gitk interaction".

I have done the same "create temporary fork of gitk, queue the patches, merge the result down while asking Paul to pull from me" dance I did every once in a while in the past (it seems the last I did it was in Sep 2019 [*]).

 * The last merge from Paulus is ef9b086d (Merge branch 'master' of
   git://git.ozlabs.org/~paulus/gitk, 2022-05-11), whose second
   parent (i.e. Paulus's tip) was 465f0386 (gitk: include y coord in
   recorded sash position, 2022-02-20).
 * The two patches that originate from GfW have been applied on top
   of 465f0386 in the gitk history; the result of this is 7dd272ec
   (gitk: escape file paths before piping to git log, 2023-01-24).
 * The js/gitk-fixes-from-gfw topic holds a -Xsubtree=gitk-git merge
   of 7dd272ec into my tree.  This was merged to 'next' and
   hopefully will finish the usual 'next' to 'master' journey
   soonish.

Paul, can you fetch js/gitk-fixes-from-gfw branch of https://github.com/gitster/git/, which will give you 7dd272ec that you can use to

 $ git merge 7dd272ec
to obtain these two commits from Johannes and Nico?

Alternatively, you can fetch 'seen' from any of the mirrors, as it hopefully should always contain that topic from now on.

Thanks.
[References]
* https://lore.kernel.org/git/xmqqlfum7epn.fsf@gitster-ct.c.googlers.com/
Previous: Felipe ContrerasNext: Felipe Contreras
Message 9 of 10 in “gitk: handle long command-lines”
  1. 0/2 gitk: handle long command-linesJohannes Schindelin via GitGitGadget, Jan 24, 2023
  2. 1/2 gitk: prevent overly long command linesJohannes Schindelin via GitGitGadget, Jan 24, 2023
  3. Junio C HamanoJan 24, 2023
  4. 2/2 gitk: escape file paths before piping to git logNico Rieck via GitGitGadget, Jan 24, 2023
  5. Johannes SchindelinMar 27, 2023
  6. Felipe ContrerasMar 27, 2023
  7. Philip OakleyMay 6, 2023
  8. New canonical gitk urlFelipe Contreras, May 7, 2023
  9. Junio C HamanoMay 8, 2023
  10. Felipe ContrerasMay 9, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.