git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff --stat: add config option to limit filename width

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 12, 2023, 17:11 UTC
Message-ID
<xmqqbke7pb8z.fsf@gitster.g>
In-Reply-To
<487bd30e5a4cdcea8697393eb36ce3f3@manjaro.org>
Dragan Simic <dsimic@manjaro.org> writes:
Show 7 quoted lines
>> Someday, as a follow-up after the dust from this topic settles, we
>> would probably want to look at how these rev.diffopt.* members are
>> initialized and refactor the common code out to a helper.  It would
>> allow us to instead of doing this ...
>
> Another good point.  If you agree, I'd prefer to have my patch
> accepted and merged as-is, ...
That is exactly what I meant by "follow-up after the dust settles".

All of the "we should probably do this and that in the future" are called #leftoverbits comments. Food for thought, something people can use to find inspiration for areas they may want to work on, that has no impact to how "complete" the current patch being discussed is.

Previous: Dragan SimicNext: Dragan Simic
Message 4 of 8 in “diff --stat: add config option to limit filename width”
  1. diff --stat: add config option to limit filename widthDragan Simic, Sep 11, 2023
  2. Junio C HamanoSep 11, 2023
  3. Dragan SimicSep 12, 2023
  4. Junio C HamanoSep 12, 2023
  5. Dragan SimicSep 12, 2023
  6. Dragan SimicSep 16, 2023
  7. Junio C HamanoSep 18, 2023
  8. Dragan SimicSep 19, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.