Re: problem with parsing of patch files for patch-id

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 21, 2024, 17:05 UTC
Message-ID: <xmqqbk3uns4s.fsf@gitster.g>
In-Reply-To: <CAP0H_AEd1jFNB_dO=HRjwEUKzFqnjntss_1wskKU6hE1VmBs+A@mail.gmail.com>

Rob Linden <rlinden@redhat.com> writes:

> This patch (also attached) fixes it by only considering commit hashes
> in a "From xxxxx..." line:

If I am not mistaken, "git patch-id" was designed to read from

    git rev-list ... commit range ... | git diff-tree --stdin -p

where we see

    9005149a4a77e2d3409c6127bf4fd1a0893c3495
    diff --git a/path b/path
    index ...
    ... patch text here ...

so I would suspect that limiting the commit object names only to those that follow "From " (i.e. the format-patch output or output with the "--format=email" option) would break existing use cases big time.