Re: [PATCH 2/2] maintenance: add loose-objects.batchSize config

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 24, 2025, 06:11 UTC
Message-ID: <xmqqbjtrot4e.fsf@gitster.g>
In-Reply-To: <6ed537862fa7585928fde33d21b77367a7fb708d.1742777512.git.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Derrick Stolee <stolee@gmail.com>
>
> The 'loose-objects' task of 'git maintenance run' first deletes loose
> objects that exit within packfiles and then collects loose objects into

"exit" -> "exist"? It may read better to also do "collects" -> "collects remaining".

Show 8 quoted lines

> a packfile. This second step uses an implicit limit of fifty thousand
> that cannot be modified by users.
>
> Add a new config option that allows this limit to be adjusted or ignored
> entirely.
>
> While creating tests for this option, I noticed that actually there was
> an off-by-one error due to the strict comparison in the limit check.

Ahh, I, contrary to my usual routine, started reading from the code change before reading the proposed log message and was wondering about this exact point.

> +	/* If batch_size is INT_MAX, then this will return 0 always. */

Cute ;-).

>  	return ++(d->count) > d->batch_size;
>  }