git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/4] line-log: route -L output through the standard diff pipeline

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 31, 2026, 21:49 UTC
Message-ID
<xmqqbjg3y8i9.fsf@gitster.g>
In-Reply-To
<pull.2065.v2.git.1773714095.gitgitgadget@gmail.com>
"Michael Montalbo via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 18 quoted lines
> Known limitations not addressed in this series:
>
>  * line_log_print() still calls show_log() and diff_flush() directly,
>    bypassing log_tree_diff_flush(). The early return in log_tree_commit()
>    (and its associated NEEDSWORK about no_free not being restored) is
>    pre-existing. Restructuring -L to flow through log_tree_diff_flush() is a
>    larger change that would affect separator and header logic; it is left
>    for a follow-up.
>
>  * Non-patch diff formats (--raw, --numstat, --stat, etc.) remain
>    unimplemented for -L.
>
> cc: "Kristoffer Haugsbakk" kristofferhaugsbakk@fastmail.com
>
> Changes since v1:
>
>  * Patch 4/4: fix documentation formatting: use line continuation
>    instead of indentation (Kristoffer Haugsbakk)

The central part of the series (i.e., patch #2) looked quite sensible. I haven't read the tests very carefully, though.

I was hoping that we will see another set of eyes or two to help review this series, but nothing has happend in the past few weeks, so let's mark the topic for 'next'.

Thanks.
Previous: Michael Montalbo via GitGitGadget
Message 18 of 18 in “line-log: route -L output through the standard diff pipeline”
  1. 0/4 line-log: route -L output through the standard diff pipelineMichael Montalbo via GitGitGadget, Mar 7, 2026
  2. 1/4 line-log: fix crash when combined with pickaxe optionsMichael Montalbo via GitGitGadget, Mar 7, 2026
  3. 2/4 line-log: route -L output through the standard diff pipelineMichael Montalbo via GitGitGadget, Mar 7, 2026
  4. 3/4 t4211: add tests for -L with standard diff optionsMichael Montalbo via GitGitGadget, Mar 7, 2026
  5. 4/4 doc: note that -L supports patch formatting and pickaxe optionsMichael Montalbo via GitGitGadget, Mar 7, 2026
  6. Kristoffer HaugsbakkMar 11, 2026
  7. Michael MontalboMar 11, 2026
  8. Junio C HamanoMar 7, 2026
  9. Michael MontalboMar 7, 2026
  10. Junio C HamanoMar 7, 2026
  11. Michael MontalboMar 7, 2026
  12. 0/4 line-log: route -L output through the standard diff pipelineMichael Montalbo via GitGitGadget, Mar 17, 2026
  13. 1/4 line-log: fix crash when combined with pickaxe optionsMichael Montalbo via GitGitGadget, Mar 17, 2026
  14. 2/4 line-log: route -L output through the standard diff pipelineMichael Montalbo via GitGitGadget, Mar 17, 2026
  15. Junio C HamanoMar 17, 2026
  16. 3/4 t4211: add tests for -L with standard diff optionsMichael Montalbo via GitGitGadget, Mar 17, 2026
  17. 4/4 doc: note that -L supports patch formatting and pickaxe optionsMichael Montalbo via GitGitGadget, Mar 17, 2026
  18. Junio C HamanoMar 31, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.