Re: [PATCH v2] diff: avoid misleading statement about -l option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 14, 2026, 14:26 UTC
- Message-ID
- <xmqqbjb4rd5q.fsf@gitster.g>
- In-Reply-To
- <pull.2035.v2.git.1786673186855.gitgitgadget@gmail.com>
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 10 quoted lines
> diff --git a/diff.c b/diff.c
> index 589c1969e4..c593066592 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -6186,7 +6186,7 @@ struct option *add_diff_options(const struct option *opts,
> N_("continue listing the history of a file beyond renames"),
> PARSE_OPT_NOARG, diff_opt_follow),
> OPT_INTEGER('l', NULL, &options->rename_limit,
> - N_("prevent rename/copy detection if the number of rename/copy targets exceeds given limit")),
> + N_("limit to cheap rename/copy detection if the number of rename/copy targets exceeds this value")),That is still a mouthful and it does not help that rename/copy appears twice, but that trait is shared with the original, so let's leave it outside the topic to improve it. If somebody is inclined to, he or she can do so later.
Will mark it for 'next'. Thanks.
Show 5 quoted lines
>
> OPT_GROUP(N_("Diff algorithm options")),
> OPT_CALLBACK_F(0, "minimal", options, NULL,
>
> base-commit: 2c78326f810173a4f3aefd8021f1e07575412481