git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Outreachy PATCH v2] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 26, 2026, 18:10 UTC
Message-ID
<xmqqbj8gqqmq.fsf@gitster.g>
In-Reply-To
<20261014114904.85300-1-okhuomonajayi54@gmail.com>
Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:
Show 9 quoted lines
> Since 84325f0730 (merge,diff: remove the_repository check before
> prefetching blobs, 2026-02-21), diffcore-break.c no longer references
> the_repository, so it does not need USE_THE_REPOSITORY_VARIABLE.
>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
> Changes since v1:
> - Removed the last paragraph of the commit message, as suggested by
>   Usman. No code was changed.
Thanks for writing and reviewing.  Will queue.
Show 17 quoted lines
>
>  diffcore-break.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/diffcore-break.c b/diffcore-break.c
> index b5bcc956cc..71d0e48beb 100644
> --- a/diffcore-break.c
> +++ b/diffcore-break.c
> @@ -2,8 +2,6 @@
>   * Copyright (C) 2005 Junio C Hamano
>   */
>  
> -#define USE_THE_REPOSITORY_VARIABLE
> -
>  #include "git-compat-util.h"
>  #include "diffcore.h"
>  #include "hash.h"
Previous: Okhuomon Ajayi
Message 7 of 7 in “diffcore-break: remove USE_THE_REPOSITORY_VARIABLE”
  1. diffcore-break: remove USE_THE_REPOSITORY_VARIABLEOkhuomon Ajayi, Oct 14, 2026
  2. Usman AkinyemiOct 14, 2026
  3. Okhuomon AjayiOct 14, 2026
  4. Usman AkinyemiOct 14, 2026
  5. Okhuomon AjayiOct 14, 2026
  6. diffcore-break: remove USE_THE_REPOSITORY_VARIABLEOkhuomon Ajayi, Oct 14, 2026
  7. Junio C HamanoOct 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.