Re: [PATCH 2/2] gitweb: Option to not display information about owner

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 26, 2012, 15:53 UTC
Message-ID: <xmqqaa1ya3rh.fsf@junio.mtv.corp.google.com>
In-Reply-To: <20120426150721.GG16489@camk.edu.pl>

Kacper Kornet <draenog@pld-linux.org> writes:

Show 12 quoted lines

>> I am guessing both #5401 and #5551 are $it->{'category'} of @projects[]
>> elements.
>
> Yes, I have tested the tree with:
>
> gitweb: Improve repository verification
> gitweb: Option to omit column with time of the last change
> gitweb: Option to not display information about owner
>
> applied on top of v1.7.10. And all tests except 't91??' are passed.
> Could you write on top of which revision have you applied these three
> patches?

Let's see...

$ git log --oneline --first-parent --boundary master..kk/gitweb-omit-expensive
37e2621 gitweb: Option to not display information about owner
5710be4 gitweb: Option to omit column with time of the last change
75e0dff gitweb: Don't set owner if got empty value from projects.list
- fdec2eb Merge branch 'maint-1.7.9' into maint

I replayed these three on v1.7.10^0

$ git checkout v1.7.10^0 $ git format-patch --stdout fdec2eb..kk/gitweb-omit-expensive | git am -s3c

and the result fails exactly the same way, though.

*** prove ***
t9500-gitweb-standalone-no-errors.sh .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 2/117 subtests
        (less 2 skipped subtests: 113 okay)

Test Summary Report
-------------------
t9500-gitweb-standalone-no-errors.sh (Wstat: 256 Tests: 117 Failed: 2)
  Failed tests:  116-117
  Non-zero exit status: 1
Files=1, Tests=117, 15 wallclock secs ( 0.07 usr  0.00 sys + 10.18 cusr  1.42 csys = 11.67 CPU)
Result: FAIL
make[1]: *** [prove] Error 1
make[1]: Leaving directory `/srv/git/t'
make: *** [test] Error 2