Re: [PATCH 1/2] prefer xwrite instead of write

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 17, 2014, 20:07 UTC
Message-ID: <xmqqa9euwex8.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140117200236.GA18964@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 13 quoted lines

> Junio C Hamano wrote:
>> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>>> Shouldn't this use write_in_full() to avoid a silently truncated result? (*)
>>
>> Meaning this?  If so, I think it makes sense.
> [...]
>> -	if (xwrite(fd, out.buf, out.len) < 0)
>> +	if (write_in_full(fd, out.buf, out.len) != out.len)
>
> Yes.  Either '< 0' or '!= out.len' would work fine here, since
> write_in_full is defined to always either write the full 'count'
> bytes or return an error.

An unrelated tangent but we may want to fix majority of callers that do not seem to know that ;-)

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.